[BUGFIX release] Refactor Model.reopen to use mixins #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,11 @@ import { assert, deprecate } from "ember-data/-private/debug"; | |||
| import { PromiseObject } from "ember-data/-private/system/promise-proxies"; | |||
| import Errors from "ember-data/-private/system/model/errors"; | |||
| import isEnabled from 'ember-data/-private/features'; | |||
| import DebuggerInfoMixin from 'ember-data/-private/system/debug/debug-info'; | |||
There was a problem hiding this comment.
I guess with that, this line in addon/-private/system/debug.js can be removed then: the Model is imported in addon/-private/system/debug/debug-adapter.js...
There was a problem hiding this comment.
I removed the linked line from system/debug.js.
This fixes bugs where users import Model form 'ember-data/model' and it was missing required methods
|
LGTM 👍 |
|
LGTM |
bmac
added a commit
that referenced
this pull request
Jan 18, 2016
[BUGFIX release] Refactor Model.reopen to use mixins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs where users import Model form 'ember-data/model' and it was missing required methods