calling reload multiple times on a has many triggers only one request #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { id: 2, body: "Second" } | ||
| ]; | ||
| resolve(value); | ||
| }, 100); |
There was a problem hiding this comment.
Lets drop the setTimeout and instead return:
return Ember.RSVP.resolve([
{ id: 1, body: "First" },
{ id: 2, body: "Second" }
]);There was a problem hiding this comment.
I thought there must be a setTimeout in order to be "sure" the multiple reloads where not resolved. But for sure it's better if I can avoid that. Will do this :)
|
@bmac Done. So I have to wrap the promises inside a promiseManyArray in order to be able to check the promise state. This seems to work, but I wonder if it's the right way even if I don't think we have an other way now to check the state of Promises |
|
LGTM |
|
LGTM 👍 |
bmac
added a commit
that referenced
this pull request
Feb 17, 2016
calling reload multiple times on a has many triggers only one request
|
Thanks @sly7-7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2327
cc @igorT @wecc