remove container related deprecation warnings

[sly7-7]

Closes #4151

It seems like some code was forgotten during the addonization.
Thanks to @rwjblue pointing it to me.

[pangratz]

#4158 fixes the failing test in this PR. After that one has merged and this PR is rebased, I think this is good to go 🚀

[sly7-7]

@pangratz I was working on the failing test too, I've integrated the change in this PR. I've also removed the env.container.destroy thing (is this necessary though ?)

[pangratz]

We are not consistent with properly destroying the env created via setupSore/createStore in the tests. Sometimes only the store is destroyed, sometimes the container, sometimes both 😆 Eventually the test setup should be consistent.

I've also removed the env.container.destroy thing (is this necessary though ?)

I think it should be kept for now. It doesn't hurt I guess...

[sly7-7]

@pangratz I will bring back the env.container.destroy. It was just that the tests were passing without this (I like to remove LOC when the tests pass 😄 )
Anyway, I don't know if it would be possible, but it would be great if we could add a unique afterEach hook doing the dirty work for all the tests. So we don't have to care about destroying (or not) env in each tests.

[rwjblue]

I don't know if it would be possible, but it would be great if we could add a unique afterEach hook doing the dirty work for all the tests. So we don't have to care about destroying (or not) env in each tests.

We can add a QUnit.testDone (see here).

[rwjblue]

But I suppose that can be a separate PR since this passes fine without...

[rwjblue]

This looks good to me...

[bmac]

Thanks @sly7-7