[CLEANUP] Remove shim for Backburner.join #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shim was added a long while back when we could not rely on the version of Backburner that Ember was using to have the `join()` function. Any currently supported version of Ember (2.x) should have this now. Similarly, any currently supported (2.x) version of Ember also has `Ember._Backburner` available. Shim was added in: emberjs#2608 `Backburner.join()` was added in: BackburnerJS/backburner.js#119
bmac
added a commit
that referenced
this pull request
Feb 19, 2016
[CLEANUP] Remove shim for Backburner.join
|
Thanks @HeroicEric |
|
not sure if it's related, but this makes a test fail on travis: |
|
I just restarted travis to see if its related to this change. It looks like travis said the pr was green before I merged it... |
|
@bmac thanks, it passes now. Maybe an unexpected latency on the server, or something like that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shim was added a long while back when we could not rely on the version of Backburner that Ember was using to have the
join()function.Any currently supported version of Ember (2.x) should have this now.
Similarly, any currently supported (2.x) version of Ember also has
Ember._Backburneravailable.Shim was added in:
#2608
Backburner.join()was added in:BackburnerJS/backburner.js#119