[BUGFIX beta] The adapter should call ajax instead of the new metho…
#4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +100,7 @@ var JSONAPIAdapter = RESTAdapter.extend({ | |||
| @return {Promise} promise | |||
| */ | |||
| findMany(store, type, ids, snapshots) { | |||
| if (isEnabled('ds-improved-ajax')) { | |||
| if (isEnabled('ds-improved-ajax') && !this._hasCustomizedAjax()) { | |||
There was a problem hiding this comment.
This only works if we support ember-cli/babel-plugin-feature-flags#4. Are the necessary dependencies in ember-data updated so this is satisfied? I'm just asking; haven't had time to follow recent developments in ember-data too closely...
There was a problem hiding this comment.
Should be allowed, as that was released as 0.2.1 and we are depending on ^0.2.0 (see here).
There was a problem hiding this comment.
Ah, awesome. Sorry for making you check this, I realize I could have easily done this myself 😔
|
Apart from a few comments, this looks great! Thanks @bmac for tackling this! |
…ds if it has been customized.
bmac
force-pushed
the
improved-ajax-fallback
branch
from
de3f396
to
7c94e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ds if it has been customized.
cc @pangratz @rwjblue