Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP don't serialize new belongsTo relationship #4500

Closed
wants to merge 1 commit into from
Closed

WIP don't serialize new belongsTo relationship #4500

wants to merge 1 commit into from

Conversation

pangratz
Copy link
Member

This addresses #4426

wecc
wecc reviewed Oct 21, 2016
View reviewed changes
tests/integration/serializers/json-api-serializer-test.js
type: 'handles',
id: '1',
relationships: {
user: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the whole user relationship be absent instead of data: null?

@samselikoff
Copy link
Contributor

I agree with @wecc, data: null is a positive statement that "this relationship is now null", whereas in most of these situations, the relationship is never null, it's just going from one state to some future state (once the id is known).

@ryanto ryanto mentioned this pull request Jan 5, 2018
Merged
@pangratz
Copy link
Member Author

Added in #5317, thanks @ryanto for pushing this forward ❤️ 👍 .

@pangratz pangratz closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wecc wecc wecc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pangratz @samselikoff @wecc