isUpdating should be true only if a reload happens #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`findAll` should not set `isUpdating` to true if `backgroundReload` or `shouldBackgroundReloadAll` returns false
wongpeiyi
force-pushed
the
fix-isUpdating-without-reload
branch
from
ccc176b
to
c12fff9
Compare
|
Thanks @wongpeiyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4527 for jsbin
I think this was fixed incorrectly in #4386 –
isUpdatingwould be true on the returned cached array even ifbackgroundReloadorshouldBackgroundReloadAllis false