Warn when findRecord returns a different id than the one requested #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
reviewed
Oct 20, 2016
| @@ -38,6 +38,11 @@ export function _find(adapter, store, typeClass, id, internalModel, options) { | |||
| return store._adapterRun(function() { | |||
| var payload = normalizeResponseHelper(serializer, store, typeClass, adapterPayload, id, 'findRecord'); | |||
| assert('Ember Data expected the primary data returned from a `findRecord` response to be an object but instead it found an array.', !Array.isArray(payload.data)); | |||
|
|
|||
| warn(`You requested a record of type '${typeClass.modelName}' with id '${id}' but the adapter returned a payload with primary data having an id of '${payload.data.id}'. Looks like you want to use store.queryRecord instead http://emberjs.com/api/data/classes/DS.Store.html#method_queryRecord`, payload.data.id === id, { | |||
There was a problem hiding this comment.
I'm worried that out of the box store.queryRecord doesn't solve this problem out of the box and the documentation linked isn't doesn't point the user toward an actionable fix for the problem this is warning about.
There was a problem hiding this comment.
Hmm, I see your concern 😔 . But I don't see how this issue could be solved other than queryRecord. I will try to update the docs and this warning...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem stumbled over in #4414.
Basically we can't
asserthere as this would be a breaking change, since the bug mostly will not occur unless you try to reload the originally requested record again.cc @igorT