[DOC] Mark errorsHashToArray and errorsArrayToHash public
#4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
suggested changes
Oct 21, 2016
| // source: { pointer: "/data/attributes/age" } | ||
| // } | ||
| // ] | ||
| let errorsArray = errorsHashToArray(errors); |
There was a problem hiding this comment.
I would put this line above the commented object that shows the value of errorsArray.
| // "name": ["Must be present"], | ||
| // "age": ["Must be present", "must be a number"] | ||
| // } | ||
| let errors = errorsArrayToHash(errorsArray); |
|
Overall I'm 👍 on this change. |
This methods are already present on the `DS` namespace, so this change marks the officially as public and adds documentation how they can be used.
|
@bmac thanks. Done. |
bmac
approved these changes
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This methods are already present on the
DSnamespace, so this changemarks the officially as public and adds documentation how they can be
used.