Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] HasMany doesn't need to inform RecordArrayManager #4644

Merged
merged 1 commit into from
Nov 11, 2016
Merged

[PERF] HasMany doesn't need to inform RecordArrayManager #4644

merged 1 commit into from
Nov 11, 2016

Conversation

stefanpenner
Copy link
Member

At one point, relationships were managed by the recordArrayManager, this is no longer true. But we still spuriously inform the manager when we flush a relationship

@stefanpenner
[PERF] HasMany doesn't need to inform RecordArrayManager
0af1903 
At one point, relationships were managed by the recordArrayManager, this is no longer true. But we still spuriously inform the manager when we flush a relationship
@fivetanley fivetanley merged commit aa9780f into master Nov 11, 2016
@fivetanley fivetanley deleted the relationship-status-complicated branch November 11, 2016 22:21
@stefanpenner
Copy link
Member Author

It may be that this is actually required #4646 sorta implies that it may be. But if thats the case, we need better tests. We can restore if #4646 ends up informing that this should happen, but \w tests and performantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @fivetanley