Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirty check to prevent liveRecordArrays being rebuilt too often #4661

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Nov 16, 2016

Every call to peekAll currently forces us to completely rebuild the live array. This is a stop gap until recordArrayManager can be improved ( @stefanpenner and I have been brainstorming our way through how to improve it.).

@runspired
Copy link
Contributor Author

@bmac test failure looks to just be a random appveyor crash, I don't think I'm allowed to restart it though.

@bmac
Copy link
Member

bmac commented Nov 16, 2016

I think @igorT is the only one who can restart appveyor. When travis is green, I've been ignoring appveyor crashes due to network errors like that and merging with with a failing appveyor build if the pr doesn't make any changes to Ember Data's build.

The appveyor check is mostly to make sure windows developers can contribute to Ember Data. So there is a very low risk of breaking the experience for windows devs if changes don't add new dependencies or change the build logic.

@bmac bmac merged commit c16ae77 into emberjs:master Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants