[BUGFIX beta] Add blueprints for "ember-cli-mocha >= 0.12.0" #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
discovered a small issue with this, do not merge for now... 😞 |
Turbo87
force-pushed
the
mocha-blueprints
branch
from
b215760
to
486aff7
Compare
pangratz
reviewed
Dec 2, 2016
| @@ -12,7 +14,12 @@ module.exports = function(blueprint) { | |||
| if ('ember-cli-qunit' in dependencies) { | |||
| type = 'qunit'; | |||
| } else if ('ember-cli-mocha' in dependencies) { | |||
| type = 'mocha'; | |||
| var checker = new VersionChecker({ project: this.project }); | |||
| if (fs.existsSync(this.path + '/mocha-0.12-files') && checker.for('ember-cli-mocha', 'npm').satisfies('>=0.12.0')) { | |||
There was a problem hiding this comment.
Why is the check for /mocha-0.12-files necessary`? Shouldn't this be the case when the addon of this version is installed?
There was a problem hiding this comment.
@pangratz that check allows us to have some blueprints that care about the Mocha version and others that don't. This is not technically needed in this case, but I've reused the code from emberjs/ember.js#14670 to reduce differences.
|
🚀 🎉 thanks a bunch @Turbo87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4689