[FIX backburner] Avoids spinning up unnecessary run loops via run.join #4698
+22
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Numbers are measuring
store._push
for238
records of a single type, in milliseconds and from 35 runs comparing current master to this PR.current master
PR
cc @stefanpenner @krisselden
Edit
I realized I should have been benchmarking against the
complex
scenario in which we actually have relationships. The complex scenario loads 34 primary records with 6 related record per primary record, for the same total of 238 records. New numbers below, before going "wait, where's the improvement?!" please see updated analysis in the related PR #4668current master
PR