[BUGFIX beta] Ensure ISO-8601 regex correctly matches timestamps #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a timezone offset
fivetanley
reviewed
Jan 26, 2017
| @@ -46,9 +46,19 @@ test("#deserialize with different offset formats", function(assert) { | |||
| var dateStringColon = '2013-03-15T23:22:00.000+00:00'; | |||
| var dateStringShortOffset = '2016-12-02T17:30:00.000+00'; | |||
|
|
|||
| assert.expect(6); | |||
|
|
|||
| var _dateUTC = Date.UTC; | |||
There was a problem hiding this comment.
we should wrap this in a try/finally so that the original Date.UTC always gets restored.
…ts after tests complete
bmac
pushed a commit
that referenced
this pull request
Jan 26, 2017
* [BUGFIX beta] Ensure ISO-8601 regex correctly matches timestamps with a timezone offset * Wrap Date prototype stubbing in try/finally to ensure it always reverts after tests complete (cherry picked from commit 3506441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case that a timestamp with a timezone offset matches the regex and correctly calls Date.UTC rather than native Date.parse.
See #4764