[DOC] shorthand methods and quotes for json-api serializer #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't kick the AppVeyor build cc @igorT |
locks
reviewed
Jan 27, 2017
| @@ -27,7 +27,7 @@ const dasherize = Ember.String.dasherize; | |||
| ```js | |||
There was a problem hiding this comment.
can you update this with the actual file path, like the rest?
locks
reviewed
Jan 27, 2017
|
|
||
| // models/player.js | ||
| import DS from "ember-data"; | ||
| const { attr, belongsTo } = DS; |
There was a problem hiding this comment.
can you revert the destructuring? ;X
There was a problem hiding this comment.
Seems inconsistent, since they are used in other examples. Should those be removed?
There was a problem hiding this comment.
Hm, I personally think so, but we should get some data team consensus.
There was a problem hiding this comment.
(I thought the docs didn't use destructuring, like Ember/Guides)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.