Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup things and stuff #4831

Merged
merged 25 commits into from
Mar 1, 2017
Merged

Cleanup things and stuff #4831

merged 25 commits into from
Mar 1, 2017

Conversation

stefanpenner
Copy link
Member

No description provided.

@stefanpenner
Copy link
Member Author

failing test:

> ember-data@2.13.0-canary test:optional-features /home/travis/build/emberjs/data
> ember test --environment=test-optional-features
npm ERR! argv "/home/travis/.nvm/versions/node/v4.8.0/bin/node" "/home/travis/.nvm/versions/node/v4.8.0/bin/npm" "run-script" "test:optional-features"
1020) [PhantomJS 2.1] unit/model - DS.Model: Using rollbackAttribute on an in-flight record reverts to the latest in-flight value
     Died on test #5 http://localhost:7357/assets/tests.js:30851:21
exports@http://localhost:7357/assets/vendor.js:127:37
requireModule@http://localhost:7357/assets/vendor.js:42:25
require@http://localhost:7357/assets/test-support.js:4678:14
loadModules@http://localhost:7357/assets/test-support.js:4670:21
load@http://localhost:7357/assets/test-support.js:4700:33
http://localhost:7357/assets/test-support.js:4584:22: undefined is not a function (evaluating 'finishSaving()')
     http://localhost:7357/assets/tests.js:30888:21
     run@http://localhost:7357/assets/vendor.js:11267:28
     run@http://localhost:7357/assets/vendor.js:32793:32
     http://localhost:7357/assets/tests.js:30864:17
     runTest@http://localhost:7357/assets/test-support.js:849:32
     run@http://localhost:7357/assets/test-support.js:834:11
     http://localhost:7357/assets/test-support.js:976:14
     process@http://localhost:7357/assets/test-support.js:635:24
     begin@http://localhost:7357/assets/test-support.js:617:9
     http://localhost:7357/assets/test-support.js:677:9
1021) [PhantomJS 2.1] unit/model - DS.Model: Saving an in-flight record updates the in-flight value rollbackAttribute will use
     Died on test #1 http://localhost:7357/assets/tests.js:30894:21
exports@http://localhost:7357/assets/vendor.js:127:37
requireModule@http://localhost:7357/assets/vendor.js:42:25
require@http://localhost:7357/assets/test-support.js:4678:14
loadModules@http://localhost:7357/assets/test-support.js:4670:21
load@http://localhost:7357/assets/test-support.js:4700:33
http://localhost:7357/assets/test-support.js:4584:22: Assertion Failed: You have turned on testing mode, which disabled the run-loop's autorun. You will need to wrap any code with asynchronous side-effects in a run

@stefanpenner stefanpenner force-pushed the cleanup-things-and-stuff branch 2 times, most recently from 357071e to a144a4a Compare March 1, 2017 17:24
Copy link
Member

@hjdivad hjdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanpenner stefanpenner merged commit 7f590d8 into master Mar 1, 2017
@stefanpenner stefanpenner deleted the cleanup-things-and-stuff branch March 1, 2017 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants