Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCUMENTATION] Refer the RFC process for requesting new features #4905

Merged
merged 1 commit into from
Mar 28, 2017
Merged

[DOCUMENTATION] Refer the RFC process for requesting new features #4905

merged 1 commit into from
Mar 28, 2017

Conversation

sduquej
Copy link
Contributor

@sduquej sduquej commented Mar 27, 2017 •
edited
Loading

Closes #4238 by tackling the last remaining item:

  • add note about RFC for requesting a feature instead of opening issue on emberjs/data

@bmac
Copy link
Member

bmac commented Mar 27, 2017

Looks great. Thanks @sduquej.

@bmac
Copy link
Member

bmac commented Mar 28, 2017

The ci failures are from an issue that has been fixed on master. I'm going to merge because the build should pass now.

@bmac bmac merged commit 1bad70b into emberjs:master Mar 28, 2017
@sduquej
Copy link
Contributor Author

sduquej commented Mar 28, 2017

Thanks @bmac. Would've been happy to rebase!

@sduquej sduquej deleted the contributing-rfc branch March 28, 2017 16:17
jghansell added a commit to swarmbox/data that referenced this pull request Jun 7, 2023
@jghansell
[BUG emberjs#4905] Fix Invalid Model dirtyType
6fbda02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmac bmac bmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sduquej @bmac