Change setupStore helper default serializer to JSONAPISerializer #4754 #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatson5
reviewed
Jun 5, 2017
tests/integration/filter-test.js
Outdated
| data: { | ||
| id: snapshot.id, | ||
| type: model.modelName, | ||
| attributes: Ember.merge(Ember.merge({}, snapshot._attributes)) |
There was a problem hiding this comment.
Do we still need to specify Ember.merge here twice if we aren't merging the id?
|
@bmac This touches a lot of things, but is a nice cleanup. Any objections to merging? |
bmac
approved these changes
Jun 13, 2017
|
Sound good to me @hjdivad. |
|
Thanks for your contribution @eshtadc! |
runspired
pushed a commit
to runspired/data
that referenced
this pull request
Jun 16, 2017
…rjs#4754 (emberjs#5003) * Change setupStore helper default serializer to JSONAPISerializer emberjs#4754 * Update test per review feedback
sudowork
pushed a commit
to sudowork/data
that referenced
this pull request
Jun 20, 2017
…rjs#4754 (emberjs#5003) * Change setupStore helper default serializer to JSONAPISerializer emberjs#4754 * Update test per review feedback
|
@eshtadc awesome!! 🎉 🚀 |
|
Is this a breaking change? It seems like it could be, but perhaps I'm missing something. |
stefanpenner
pushed a commit
to runspired/data
that referenced
this pull request
Jul 18, 2017
…ion when possible. This reverts commit 16b8a04. — The `deleteRecord() { return null; }` changes are to allow the back ported tests to work with the older JSONSerializer rather then the JSONAPISerializer which the test suite (in beta and master) use. For reference the JSONSerializer -> JSONAPISerializer landed -> emberjs#5003
stefanpenner
pushed a commit
to runspired/data
that referenced
this pull request
Jul 18, 2017
…ion when possible. This reverts commit 16b8a04. — The `deleteRecord() { return null; }` changes are to allow the back ported tests to work with the older JSONSerializer rather then the JSONAPISerializer which the test suite (in beta and master) use. For reference the JSONSerializer -> JSONAPISerializer landed -> emberjs#5003
|
@workmanw I don't think so, as it merely changed the tests to use the more modern and recommended serializer. But if you notice a regression, please share! |
|
Oh, oops. I didn't realize this change was for test setup. I thought it was for regular injection.
Side note, this is a mammoth commit. 👏 👏 |
|
@workmanw keep us honest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.