Ensure ember-data/-private module is emitted properly for ember-cli < 2.12
#5022
Conversation
… < 2.12. ember-cli@2.12 and higher have the addon itself responsible for transpiling modules so that the output of the `treeForAddon` hook is expected to be AMD. Prior versions of ember-cli (i.e. < 2.12) do second pass (that is not possible to disable) to transpile the output of `treeForAddon` **again** (to transpile modules). This commit changes things around leveraging ember-cli-babel@6's built in ability to detect the various ember-cli version scenarios and either transpile `ember-data/-private` down to AMD or not correctly.
|
This will need to be ported forward to |
|
|
||
| privateTree = new Rollup(privateTree, { | ||
| rollup: { | ||
| entry: '-private/index.js', | ||
| targets: [ | ||
| { dest: '-private.js', format: 'amd', moduleId: 'ember-data/-private' } | ||
| { dest: 'ember-data/-private.js', format: babel.shouldCompileModules() ? 'amd' : 'es', moduleId: 'ember-data/-private' } |
There was a problem hiding this comment.
should dest be subject to the same conditional as format?
There was a problem hiding this comment.
In 2.12 and higher we simply concat regardless of source path, so this is fine. In < 2.12, we need to be in the right place so that the transpiled AMD module has the right moduleId.
If you notice down below, the public modules are emitted into modules/ember-data already (in all cases). This should be fine for both sides (and the tests are passing).
There was a problem hiding this comment.
LGTM. Sorry I missed this scenario in my original implementation. Good catch @rwjblue!!
ember-cli@2.12 and higher have the addon itself responsible for transpiling modules so that the output of the
treeForAddonhook is expected to be AMD.Prior versions of ember-cli (i.e. < 2.12) do second pass (that is not possible to disable) to transpile the output of
treeForAddonagain (to transpile modules).This commit changes two things:
ember-cli-babel@6's built in ability to detect the various ember-cli version scenarios and either transpileember-data/-privatedown to AMD or not correctlybroccoli-rollupintomodules/ember-data/-private.js(previously wasmodules/-private.js). In ember-cli < 2.12, we have to ensure that the emitted file is in the correct location for that second pass module transpilation.