Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates addon to adhere to RFC 176 #5108

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Updates addon to adhere to RFC 176 #5108

merged 2 commits into from
Oct 9, 2017

Conversation

locks
Copy link
Contributor

@locks locks commented Jul 30, 2017 •
edited
Loading

This PR attempts to migrate all of the documentation and imports to adhere to RFC #176.

  • Updates documentation
  • Updates code base
  • Add modules polyfill to the globals/bower build

@locks locks force-pushed the rfc-176 branch 2 times, most recently from 5cef8a1 to ac97f3a Compare July 31, 2017 14:54
@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2017

@locks - I believe we need to add babel-plugin-ember-modules-api-polyfill to the globals/bower build. Otherwise these changes will only work for consumers using ember-data as an addon.

@stefanpenner
Copy link
Member

@locks nice. I believe the bower build stuff will also need to be update (just chatting with @rwjblue about this)

@locks
Copy link
Contributor Author

locks commented Aug 1, 2017

@tylerturdenpants this PR already touches 161 files, I think it would be best to keep it focused on imports/exports.

@stefanpenner
Copy link
Member

@locks any plans to finish this?

@locks
Copy link
Contributor Author

locks commented Aug 10, 2017

@stefanpenner yessir! I'll try to finish before the weekend, but next week is more likely.

@locks locks force-pushed the rfc-176 branch 2 times, most recently from 7f107a3 to f763576 Compare August 11, 2017 11:13
@locks
Copy link
Contributor Author

locks commented Aug 11, 2017

@stefanpenner @rwjblue please review 😁

@locks locks changed the title Updates imports in documentation to adhere to RFC 176 Updates addon to adhere to RFC 176 Aug 11, 2017
@locks locks mentioned this pull request Aug 16, 2017
Closed
6 tasks
@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2017

@locks - Sorry for the delays, I believe we are unblocked here now that #5123 has landed. Would you mind rebasing?

@locks locks force-pushed the rfc-176 branch 5 times, most recently from 36920ce to 06e1c3d Compare August 16, 2017 23:00
@locks
Copy link
Contributor Author

locks commented Aug 30, 2017

Kicked CI and now it's green, take that as you will.

rwjblue
rwjblue reviewed Aug 30, 2017
View reviewed changes
MODULE_REPORT.md
@@ -0,0 +1,1372 @@
## Module Report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be added to the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm, it was my intention for MODULE_REPORT.md to document what work might still need to be done.

@bmac
Copy link
Member

bmac commented Sep 29, 2017

@locks would you mind rebasing this pr?

@locks locks force-pushed the rfc-176 branch 5 times, most recently from 1ca44f9 to 5b4b8cc Compare October 2, 2017 15:05
@locks locks force-pushed the rfc-176 branch 3 times, most recently from 2bcdef4 to 691b2ee Compare October 8, 2017 15:44
@locks
Copy link
Contributor Author

locks commented Oct 8, 2017

Rebased and updated documentation code blocks as well.

bmac
bmac reviewed Oct 9, 2017
View reviewed changes
tests/integration/adapter/store-adapter-test.js

These tests ensure that the proper methods get called, and, if applicable,
the given record or record array changes state appropriately.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this comment get removed?

@bmac bmac merged commit 4b419d9 into master Oct 9, 2017
@bmac bmac deleted the rfc-176 branch October 9, 2017 14:46
bmac pushed a commit that referenced this pull request Oct 9, 2017
@locks @bmac
Updates addon to adhere to RFC 176 (#5108)
3a2e382 
* Updates codebase to new Ember modules API based on RFC 176

* bumps ember-cli-babel to latest 6.8

(cherry picked from commit 4b419d9)
dnachev pushed a commit to dnachev/data that referenced this pull request Oct 31, 2017
@locks
Updates addon to adhere to RFC 176 (emberjs#5108)
6dcece6 
* Updates codebase to new Ember modules API based on RFC 176

* bumps ember-cli-babel to latest 6.8
igorT pushed a commit that referenced this pull request Jan 29, 2018
@locks @igorT
Updates addon to adhere to RFC 176 (#5108)
5166632 
* Updates codebase to new Ember modules API based on RFC 176

* bumps ember-cli-babel to latest 6.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@bmac bmac bmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@locks @rwjblue @stefanpenner @bmac