[BUGFIX release] Enumerate relationships provided, not all on a given… #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
only-enumerate-relationships-provided
branch
from
1e52faf
to
19d3dd5
Compare
chadhietala
reviewed
Aug 25, 2017
|
|
||
| for (let i = 0, l = pushed.length; i < l; i += 2) { | ||
| modelNameToInverseMap = modelNameToInverseMap || Object.create(null); |
There was a problem hiding this comment.
Is it worth preventing the ToBoolean conversion here e.g. (modelNameToInverseMap !== undefined)
There was a problem hiding this comment.
I believe the cost of ToBoolean coercion in this context is negligible. I could default modelNameToInverseMap to false though, if you would prefer. That would be a minimal enough change I would feel comfortable with, although this feels like pre-mature opt territory. Let me know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… schema