Update assert against nulls #5218
Conversation
^ is failing the build on Ember 1.13 and 2.4 (but passes on 2.8+). |
|
I can't reproduce locally via |
|
#5213 looked green on travis when I merged it... |
| @@ -39,7 +39,7 @@ test("meta is proxied correctly on the PromiseArray", function(assert) { | |||
| result = store.query('person', {}); | |||
| }); | |||
|
|
|||
| assert.equal(result.get('meta.foo'), undefined); | |||
| assert.strictEqual(result.get('meta.foo'), undefined); | |||
There was a problem hiding this comment.
@pangratz I spent some time digging into this and couldn't figure out while its failing. I blame phantom weirdness. Lets leave this as assert.equal so the tests pass since the fact that this returns undefined is Ember behavior and not Ember Data.
There was a problem hiding this comment.
Correction, I was just able to reproduce it. Turns out in Ember 1.13 Ember.get({foo: null}, 'foo.bar') returns null but in Ember 2.0 Ember.get({foo: null}, 'foo.bar') returns undefined.
There was a problem hiding this comment.
Uff, thanks for tracking that one down!
I've updated this assertion to be assert.notOk.
This prevents us being trolled by QUnit, where
assert.equal(undefined, null)
is not a failing assertion.
This prevents us being trolled by QUnit, where
assert.equal(null, undefined)
is not a failing assertion.
* update assertion for meta proxied on AdapterPopulatedRecordArray
* use `assert.strictEqual` when comparing against `null`
This prevents us being trolled by QUnit, where
assert.equal(undefined, null)
is not a failing assertion.
* use `assert.strictEqual` when comparing against `undefined`
This prevents us being trolled by QUnit, where
assert.equal(null, undefined)
is not a failing assertion.
* align test for DateTransform#deserialize(undefined) with implementation
Does this make sense? Basically this is to prevent us from future
ing like reported in #5207. I am unsure if this is a good idea or if we should update the tests to use
assert.ok/assert.notOkinstead 🤔 . Basically just did a search and replace...