[BUGFIX release] Cleanup test only dependencies. #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
dependency-cleanup
branch
from
a4a6bf1
to
8781e2a
Compare
|
The failure in Travis was the one being fixed in #5224 |
rwjblue
force-pushed
the
dependency-cleanup
branch
from
8781e2a
to
def8f68
Compare
|
Rebased on top of #5224. |
rwjblue
force-pushed
the
dependency-cleanup
branch
2 times, most recently
from
04cfeec
to
7aa6943
Compare
|
@rwjblue looks like CI is still falling with a broccoli error 🤔 since both commits target different branches should we split the PR up? |
rwjblue
force-pushed
the
dependency-cleanup
branch
from
7aa6943
to
7cef718
Compare
rwjblue
changed the title
Also fixed small issue (which was being squelched by bugs in deps that have been updated here) with a merge (needed to allow overwriting).
rwjblue
force-pushed
the
dependency-cleanup
branch
from
7cef718
to
f1c685d
Compare
|
Ya, good point (will help us land this quicker). I pared this one down to just the test dependency changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some test only dependencies.
Fixes #5222