Add a test to ensure multiple stores get unique instances of serializ… #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for putting this together! |
rwjblue
requested changes
Dec 22, 2017
| let serializer_a = env.store_a.serializerFor('home-planet'); | ||
| let serializer_b = env.store_b.serializerFor('home-planet'); | ||
|
|
||
| assert.notEqual(serializer_a, serializer_b); |
There was a problem hiding this comment.
Can you add more assertions here?
Specifically, we don't actually care that they aren't the same instance (not really at least), what we care about is that .store on them is the right thing.
assert.equal(get(serializer_a, 'store'), env.store_a);
assert.equal(get(serializer_b, 'store'), env.store_b);
bmac
force-pushed
the
unique-adapter-per-store
branch
from
f584a40
to
d60c6b1
Compare
bmac
force-pushed
the
unique-adapter-per-store
branch
from
d60c6b1
to
276d026
Compare
rwjblue
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ers and adapters