Revamp eslint configuration. #5469

rwjblue · 2018-05-09T00:16:50Z

Migrate to single centralized config (via overrides).
Add eslint-plugin-node
- ensures only features for supported engines can be used
- ensures all dependencies that are required are listed in package.json dependencies
Add prettier 💅

rwjblue · 2018-05-09T00:21:22Z

Aside from running prettier (which is where the bulk of the diff comes from), you can see nearly all of the config based changes here:

rwjblue added 7 commits May 8, 2018 17:17

Update eslint configuration to use overrides.

583a09b

Move all eslint exceptions to top-level overrides.

d507bb3

Update ember-cli-eslint version.

cfc7188

Fix eslint failures.

48b1c69

Add prettier configuration to eslint.

67ac66b

Add yarn lint:js script.

1ae7502

yarn eslint --fix .

5ae301c

rwjblue force-pushed the linting-updates branch from bd6bfc8 to 5ae301c Compare May 9, 2018 00:18

runspired approved these changes May 9, 2018

View reviewed changes

runspired merged commit 6a13afe into emberjs:master May 9, 2018

rwjblue deleted the linting-updates branch July 25, 2018 00:13

Provide feedback