[FEAT] assert when methods are called on a destroyed store instance #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible to call many of these methods (perhaps accidentally) after the store was already destroyed or in the process of being destroyed. Attempting to update the state of data in a destroyed store, or add/remove data from a destroyed store is an error. Previously these errors would be difficult to diagnose, along the lines of
cannot call X of undefined, or would simply result in strange state.This PR will help folks detect other async and teardown timing issues in their applications and test suites in a friendlier way.
Replaces #5282
cc @danwenzel. Many thanks for bringing this to our attention!