[CHORE] Use model name instead of store in isPrimaryType #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
requested changes
Aug 16, 2019
runspired
added
the
🌲 Project Trim 🌲
runspired
approved these changes
Aug 20, 2019
runspired
added a commit
that referenced
this pull request
Aug 20, 2019
…)" This reverts commit a33d8ea.
runspired
added a commit
that referenced
this pull request
Aug 20, 2019
Gaurav0
pushed a commit
to Gaurav0/data
that referenced
this pull request
Dec 2, 2019
* Use model name instead of store in isPrimaryType * Fix property naming error
runspired
pushed a commit
that referenced
this pull request
Dec 2, 2019
* [CHORE] Use model name instead of store in isPrimaryType (#6338) * Use model name instead of store in isPrimaryType * Fix property naming error * fix tests * deprecate old private method rather than deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rest serializer
isPrimaryTypeto not use store anymore.Closes #5809