[FEAT] Adds support for parenless attr, belongsTo, and hasMany #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
add-paren-less-decorator-support
branch
2 times, most recently
from
bc87e0b
to
e090101
Compare
chancancode
approved these changes
Aug 17, 2019
|
Failures seem unrelated, the same tests seem to fail on master. |
pzuraq
force-pushed
the
add-paren-less-decorator-support
branch
from
e090101
to
f53f953
Compare
runspired
reviewed
Aug 20, 2019
| }, | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
can we check accessing via dot notation as well?
runspired
approved these changes
Aug 20, 2019
pzuraq
force-pushed
the
add-paren-less-decorator-support
branch
from
f53f953
to
6edc449
Compare
This was referenced Aug 23, 2019
wycats
pushed a commit
that referenced
this pull request
Sep 5, 2019
(cherry picked from commit aa05d92)
rwjblue
pushed a commit
that referenced
this pull request
Sep 6, 2019
(cherry picked from commit aa05d92)
rwjblue
added a commit
that referenced
this pull request
Sep 10, 2019
[BUGFIX beta] Adds support for parenless attr, belongsTo, and hasMany (#6339)
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only be added in modern Ember versions that support decorators. I tried to figure out how to write better tests, but I couldn't find basic unit tests to emulate, will definitely take pointers if anyone has any!