[FEAT] - add a public Typescript interface for the minimal required adapter interface #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Aug 24, 2019
| shouldReloadAll(store: any, snapshots: any[]): boolean; | ||
| shouldBackgroundReloadRecord(store: any, snapshot: any): boolean; | ||
| shouldBackgroundReloadAll(store: any, snapshots: any[]): boolean; | ||
| } |
There was a problem hiding this comment.
Should we more closely define object or any as Record?
There was a problem hiding this comment.
store should be Store, snapshot should be Snapshot and snapshots should be SnapshotRecordArray, the return values of the promises should probably be unknown although any might be just as fine here.
There was a problem hiding this comment.
I'm assuming we need to make typescript interfaces for these constructs as well then to consider this PR mergeable?
runspired
added
the
🌲 Project Trim 🌲
|
replacing with #6643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6166
Ref #6113