[DOC] Added URL to queryRecord deprecation warning
#6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
previously requested changes
Sep 9, 2019
| @@ -286,8 +286,10 @@ const RESTSerializer = JSONSerializer.extend({ | |||
| 'The adapter returned an array for the primary data of a `queryRecord` response. This is deprecated as `queryRecord` should return a single record.'; | |||
|
|
|||
| deprecate(message, !isQueryRecordAnArray, { | |||
| id: 'ds.serializer.rest.queryRecord-array-response', | |||
There was a problem hiding this comment.
I have concerns about changing the ID of the deprecation post-release. Also I think I agree that we should just change this to an assert at this point. Thoughts @rwjblue ?
yohanmishkin
force-pushed
the
tj/deprecation-warning-url-queryRecord
branch
from
cd31f9c
to
8328fbd
Compare
rwjblue
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this deprecation should be removed altogether (and throw some kind of error) since we've passed 3.0?