Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX 3.12] Backport Symbol fix #6416

Merged
merged 2 commits into from
Sep 11, 2019
Merged

[BUGFIX 3.12] Backport Symbol fix #6416

merged 2 commits into from
Sep 11, 2019

Conversation

dcyriller
Copy link
Contributor

@dcyriller dcyriller commented Sep 10, 2019

Port #6389 to 3.12

This solves will close #6389

🚧 We have to re-target this PR against a release-3.12 branch, that need to be created. ⚠️ EDIT: done

@rwjblue
Copy link
Member

rwjblue commented Sep 10, 2019

@dcyriller release is 3.12 (we only make the release-x-y branches when the specific release is not the current release).

@rwjblue rwjblue changed the base branch from master to release September 10, 2019 10:24
@rwjblue
Copy link
Member

rwjblue commented Sep 10, 2019

Changed target, and kicked off CI again.

@dcyriller
Copy link
Contributor Author

dcyriller commented Sep 10, 2019

Okay! Thanks

EDIT: These two tests fail. It seems unrelated to this PR though. Indeed, I remember having seen them in another fix for the 3.11 branch:

 33) [Chrome 77.0] integration/adapter/find-all - Finding All Records of a Type: When all records for a type are requested, records that are created on the client should be added to the record array.
     the record array's length is 1

     expected: 1
       actual: 0

257) [Chrome 77.0] unit/record-array - RecordArray: a newly created record is removed from a record array when it is deleted
     precond - record array already has the first created item

     expected: 1
       actual: 0

These occurences of Symbol might be replaced by this `symbol`, similar
but different in the sense it is iterable.
@dcyriller dcyriller changed the title Backport Symbol fix to 3.12 [BUGFIX 3.12] Backport Symbol fix Sep 11, 2019
@runspired
Copy link
Contributor

I opened #6425 yesterday because I noticed the same failure @dcyriller, it is unrelated to this.

@runspired runspired merged commit 47a8052 into emberjs:release Sep 11, 2019
@runspired
Copy link
Contributor

We should also backport this to beta

@dcyriller dcyriller deleted the port-symbol-3.12 branch September 11, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants