-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Add an adapter-encapsulation-test-app package #6497
Merged
runspired
merged 5 commits into
emberjs:master
from
zinyando:zinyando/adapter-encapsulation-test-app
Sep 24, 2019
Merged
[TEST] Add an adapter-encapsulation-test-app package #6497
runspired
merged 5 commits into
emberjs:master
from
zinyando:zinyando/adapter-encapsulation-test-app
Sep 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinyando
changed the title
[WIP] Adds an adapter-encapsulation-test-app package
[TEST] Add an adapter-encapsulation-test-app package
Sep 24, 2019
runspired
requested changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! A few minor things to clean up and then we can merge :)
packages/-adapter-encapsulation-test-app/app/templates/application.hbs
Outdated
Show resolved
Hide resolved
runspired
reviewed
Sep 24, 2019
runspired
approved these changes
Sep 24, 2019
Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>
runspired
approved these changes
Sep 24, 2019
72 tasks
runspired
added
the
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
label
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an adapter-encapsulation-test-app package and smoke tests