[BUGFIX fetchOptions] fix fetchOptions to support POST body of all valid types #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Oct 7, 2019
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/adapters/rest-adapter/fetch-options-test.js
Outdated
Show resolved
Hide resolved
rwjblue
approved these changes
Oct 8, 2019
|
@runspired any other changes you'd like or questions I can answer? |
runspired
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landed some fixes to
ember-fetchin PR #174 to correctly support POSTbodys other than objects. These fixes came after these utils were added to ED.Also added several tests from ember-fetch to increase coverage for this util, some of which pertain to this change.