Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX RELEASE BETA CANARY] Fastboot issues #6683

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 6, 2019

For #6679 and partial fix for #6680

Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for the computed property seem correct, but the tsconfig change confuses me. We may just want to add the fastboot-test-app to the root tsconfig.

packages/unpublished-fastboot-test-app/tsconfig.json Outdated Show resolved Hide resolved
@igorT igorT added the ts-review label Nov 6, 2019
@Gaurav0 Gaurav0 changed the title [BUGFIX BETA CANARY] Fastboot issues [BUGFIX RELEASE BETA CANARY] Fastboot issues Nov 7, 2019
@runspired runspired merged commit 153e7ef into emberjs:master Nov 8, 2019
igorT pushed a commit that referenced this pull request Nov 8, 2019
* [BUGFIX BETA CANARY] Fastboot issues

* move tsconfig.json changes to root file

(cherry picked from commit 153e7ef)
Gaurav0 added a commit to Gaurav0/data that referenced this pull request Nov 8, 2019
* [BUGFIX BETA CANARY] Fastboot issues

* move tsconfig.json changes to root file
runspired pushed a commit that referenced this pull request Nov 9, 2019
* [BUGFIX BETA CANARY] Fastboot issues

* move tsconfig.json changes to root file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants