Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] mutations tests for adapter encapsulation side quest #6755

Merged
merged 1 commit into from
Nov 19, 2019
Merged

[TEST] mutations tests for adapter encapsulation side quest #6755

merged 1 commit into from
Nov 19, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 17, 2019

For #6666

@runspired runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🏷️ test This PR primarily adds tests for a feature 🌲 📦 Encapsulation & Interface Tests 📦 🌲 labels Nov 18, 2019
runspired
runspired approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit to cleanup but otherwise ready :) Thanks!

packages/unpublished-adapter-encapsulation-test-app/tests/integration/mutations-test.js Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/mutations-test.js Show resolved Hide resolved
@runspired runspired merged commit ca73b15 into emberjs:master Nov 19, 2019
@Gaurav0 Gaurav0 deleted the mutations_test branch November 19, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaurav0 @runspired