[CHORE] inject the Model specific _modelForMixin implementation into the store from the Model package #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the store from the Model package
Gaurav0
force-pushed
the
model_for_mixin
branch
from
ba7e83f
to
3e4d5f0
Compare
runspired
reviewed
Nov 26, 2019
| } | ||
| return _Model; | ||
| } | ||
| import { RecordInstance } from '../ts-interfaces/record-instance'; |
There was a problem hiding this comment.
RecordInstance is for the instantiated record instances, I believe based on usage below you are in need of ModelSchema or DSModelSchema
runspired
requested changes
Nov 26, 2019
| let factory = cache[normalizedModelName]; | ||
|
|
||
| if (!factory) { | ||
| factory = _lookupModelFactory(store, normalizedModelName); | ||
|
|
||
| if (!factory) { | ||
| //Support looking up mixins as base types for polymorphic relationships | ||
| factory = _modelForMixin(store, normalizedModelName); | ||
| factory = store._modelForMixin(normalizedModelName); |
There was a problem hiding this comment.
instead of adding a private method to store and injecting it from the model package, we should use the HAS_MODEL_PACKAGE build flag to conditionally import a private function from that package.
let _modelForMixin;
if (HAS_MODEL_PACKAGE) {
_modelForMixin = require('@ember-data/model/-private')._modelForMixin;
}
// ....
if (HAS_MODEL_PACKAGE) {
factory = _modelForMixin(store, normalizedModelName);
}possibly with a module scope cache for the method to avoid looking it up each time.
|
Closing in favor of #6802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6166