Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] improve comment bot #6820

Merged
merged 1 commit into from
Nov 28, 2019
Merged

[CHORE] improve comment bot #6820

merged 1 commit into from
Nov 28, 2019

Commits on Nov 27, 2019

  1. [CHORE] improve comment bot

    - changes the comment-bot to update existing comments instead of deleting old comments
    - fixes the bug that was preventing deletion of old comments
    - fixes the performance analysis script to also post a comment correctly (it's been failing to do so although trying for some time)
    
    You can see the effects of the updates (edit history on the pr comments) within this PR. Overall it seems like a good change, although I dislike how the comment time stamp remains the time of the very original comment instead of showing the time edited. This makes it harder to judge quickly if it is the most recent analysis, although checking the commit sha that is printed will verify.
    runspired committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    fe7aeb2 View commit details
    Browse the repository at this point in the history