Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] generateIdForRecord tests for adapter encapsulation side quest #6824

Merged
merged 3 commits into from
Nov 30, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 29, 2019

For #6666

Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few tiny nits.

@runspired runspired added 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🌲 📦 Encapsulation & Interface Tests 📦 🌲 labels Nov 29, 2019
@runspired runspired merged commit 2831d6b into emberjs:master Nov 30, 2019
@Gaurav0 Gaurav0 deleted the generate_id_tests branch November 30, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants