[WIP] Don't expose the value of a model's attribute in assertions

packages/-ember-data/tests/unit/model-test.js

@@ -140,9 +140,13 @@ module('unit/model - Model', function(hooks) {
         'the deleted person is not removed from store (no unload called)'
       );
 
-      assert.expectAssertion(() => {
-        set(record, 'isArchived', true);
-      }, /Attempted to set 'isArchived' to 'true' on the deleted record <person:1>/);
+      assert.expectAssertion(
+        () => {
+          set(record, 'isArchived', true);
+        },
+        /Attempted to set 'isArchived' on the deleted record <person:1>/,
+        "Assertion does not leak the 'value'"
+      );
 
       currentState = record._internalModel.currentState;
 
@@ -151,6 +155,32 @@ module('unit/model - Model', function(hooks) {
       assert.ok(get(record, 'isArchived') === false, 'The record reflects canonical state');
     });
 
+    testInDebug('Assertion for dirtying in root.deleted.saved', async function(assert) {
+      adapter.deleteRecord = () => {
+        return resolve({ data: null });
+      };
+
+      let record = store.push({
+        data: {
+          type: 'person',
+          id: '1',
+          attributes: {
+            isDrugAddict: false,
+          },
+        },
+      });
+
+      await record.destroyRecord();
+
+      assert.expectAssertion(
+        () => {
+          set(record, 'isDrugAddict', true);
+        },
+        /Attempted to set 'isDrugAddict' to 'true' on the deleted record <person:1>/,
+        'Assertion includes more context when in DEBUG'
+      );
+    });
+
     test('currentState is accessible when the record is created', async function(assert) {
       let record = store.push({
         data: {

packages/store/addon/-private/system/model/internal-model.ts

@@ -913,7 +913,11 @@ export default class InternalModel {
 
   setDirtyAttribute(key, value) {
     if (this.isDeleted()) {
-      throw new EmberError(`Attempted to set '${key}' to '${value}' on the deleted record ${this}`);
+      if (DEBUG) {
+        throw new EmberError(`Attempted to set '${key}' to '${value}' on the deleted record ${this}`);
+      } else {
+        throw new EmberError(`Attempted to set '${key}' on the deleted record ${this}`);
+      }
     }
 
     let currentValue = this.getAttributeValue(key);