Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IDENTIFIERS feature flag #7814

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Remove IDENTIFIERS feature flag #7814

merged 1 commit into from
Dec 20, 2021

Conversation

snewcomer
Copy link
Contributor

ref #6366

2 years ago it was turned on.

@snewcomer snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Dec 20, 2021
@snewcomer snewcomer self-assigned this Dec 20, 2021
@github-actions
Copy link

Asset Size Report for 216d19a

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '185.40 KB' │
│ compressed │ '39.37 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '78.12 KB' │
│  compressed  │ '16.59 KB' │
│ % Of Library │   '42.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 77.20 KB  | 16.40 KB   | 98.8          | 41.6
	@ember-data/store/index                           | 936.00 B  | 198.77 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.88 KB' │
│  compressed  │ '6.13 KB'  │
│ % Of Library │   '15.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.40 KB  | 6.03 KB    | 98.4          | 15.3
	@ember-data/model/index                           | 486.00 B  | 103.21 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.05 KB' │
│  compressed  │ '5.11 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.05 KB  | 5.11 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.73 KB' │
│  compressed  │ '4.19 KB'  │
│ % Of Library │   '10.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.20 KB   | 1.53 KB    | 36.5          | 3.9
	@ember-data/serializer/-private                   | 5.52 KB   | 1.17 KB    | 28.0          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 815.50 B   | 19.0          | 2.0
	@ember-data/serializer/rest                       | 2.80 KB   | 608.01 B   | 14.2          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 54.79 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.65 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.75 KB' │
│  compressed  │ '3.35 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.95 KB   | 1.69 KB    | 50.5          | 4.3
	@ember-data/adapter/-private                      | 3.79 KB   | 824.85 B   | 24.1          | 2.0
	@ember-data/adapter/error                         | 1.96 KB   | 425.80 B   | 12.4          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 225.32 B   | 6.6           | 0.6
	@ember-data/adapter/json-api                      | 1.01 KB   | 220.65 B   | 6.4           | 0.5

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.99 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 525.83 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 462.54 B   | 22.8          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 258.45 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 78.15 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.53 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.18 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.30 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.03 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.60 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.60 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.18 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.33 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.27 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.99 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.14 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.14 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.29 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.19 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 629.46 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.52 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 100.45 B   | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 100.02 B   | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.21 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.75 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.53 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.86 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '612.48 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 505.23 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.24 B   | 17.5          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '225.09 KB' │
│ compressed │ '42.63 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬─────────────┐
│   (index)    │   Values    │
├──────────────┼─────────────┤
│    bytes     │ '101.94 KB' │
│  compressed  │ '19.31 KB'  │
│ % Of Library │   '45.3'    │
└──────────────┴─────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.41 KB  | 3.30 KB    | 17.1          | 7.7
	@ember-data/store/-private/system/model/internal-model                             | 14.76 KB  | 2.80 KB    | 14.5          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.51 KB   | 1.04 KB    | 5.4           | 2.4
	@ember-data/store/-private/system/fetch-manager                                    | 5.16 KB   | 1001.51 B  | 5.1           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.50 KB   | 873.48 B   | 4.4           | 2.0
	@ember-data/store/-private/system/record-array-manager                             | 4.18 KB   | 811.54 B   | 4.1           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.92 KB   | 760.22 B   | 3.8           | 1.7
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.46 KB   | 670.64 B   | 3.4           | 1.5
	@ember-data/store/-private/index                                                   | 3.36 KB   | 651.70 B   | 3.3           | 1.5
	@ember-data/store/-private/system/references/has-many                              | 3.23 KB   | 626.89 B   | 3.2           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 600.75 B   | 3.0           | 1.4
	@ember-data/store/-private/system/references/belongs-to                            | 2.89 KB   | 560.60 B   | 2.8           | 1.3
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.87 KB   | 556.43 B   | 2.8           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 442.23 B   | 2.2           | 1.0
	@ember-data/store/-private/system/references/record                                | 2.02 KB   | 391.85 B   | 2.0           | 0.9
	@ember-data/store/-private/system/ds-model-store                                   | 1.94 KB   | 375.94 B   | 1.9           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 346.58 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 294.12 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 255.87 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 221.21 B   | 1.1           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 189.20 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 177.27 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 923.00 B  | 174.80 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 173.48 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 167.80 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 151.89 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 800.00 B  | 151.51 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 142.61 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 132.38 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 115.34 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.25 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 99.81 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.56 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.23 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 85.98 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.24 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.90 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.31 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.84 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.92 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.32 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 48.67 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.66 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.15 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.77 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.00 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.62 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.43 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.43 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.43 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.49 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.30 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.30 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.54 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.54 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.78 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.21 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.65 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.65 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.99 KB' │
│  compressed  │ '6.25 KB'  │
│ % Of Library │   '14.7'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 10.03 KB  | 1.90 KB    | 30.4          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.9          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.87 KB   | 749.80 B   | 11.7          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.86 KB   | 554.16 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.10 KB   | 407.19 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 275.75 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 253.21 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.52 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 160.03 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 130.30 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.72 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 92.04 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.60 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.65 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 83.71 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.87 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.09 KB' │
│  compressed  │ '5.89 KB'  │
│ % Of Library │   '13.8'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.7          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.92 KB   | 953.21 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.15 KB   | 610.60 B   | 10.1          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.86 KB   | 553.78 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 394.88 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 375.75 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 292.99 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 204.73 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 202.46 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 185.03 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 151.13 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 131.06 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 128.21 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.89 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.49 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.07 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.38 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.40 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.15 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '9.8'    │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.20 KB   | 1.36 KB    | 32.5          | 3.2
	@ember-data/serializer/-private/embedded-records-mixin     | 4.41 KB   | 855.48 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 727.26 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.80 KB   | 542.23 B   | 12.6          | 1.2
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.16 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.37 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.77 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.79 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.15 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.38 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.86 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.80 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.71 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.88 KB' │
│  compressed  │ '3.39 KB'  │
│ % Of Library │   '7.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.95 KB   | 1.51 KB    | 44.5          | 3.5
	@ember-data/adapter/error                                     | 1.96 KB   | 379.73 B   | 11.0          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 374.99 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 200.94 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 199.99 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.01 KB   | 196.77 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 790.00 B  | 149.62 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 107.57 B   | 3.1           | 0.2
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.55 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.98 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 351.00 B  | 66.47 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.04 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.84 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 468.93 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 373.86 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.49 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.69 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.69 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.22 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.89 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.53 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.40 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.02 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.02 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.64 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.88 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.93 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.80 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.04 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.04 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.28 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.49 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 561.35 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 308.14 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 89.58 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 89.20 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.64 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.66 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.22 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.06 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '546.21 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 450.56 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.64 B    | 17.5          | 0.2

@snewcomer snewcomer changed the title Remove IDENTIFIERS ff Remove IDENTIFIERS feature flag Dec 20, 2021
@github-actions
Copy link

Performance Report for 216d19a

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-31ms to 23ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-20ms to 7ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-16ms to 16ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-9ms to 8ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [0ms to 12ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [0ms to 51ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 16ms]
⚠️ Phase [start-push-payload] => [start-unload-records]
phase estimated regression +23ms [2ms to 43ms] OR +1.5% [0.12% to 2.81%]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-6ms to 5ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-22ms to 31ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-2ms to 25ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-24ms to 17ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-11ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-25ms to 19ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-24ms to 7ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-13ms to 14ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 4ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-27ms to 27ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 15ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-23ms to 16ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 2ms]

@snewcomer snewcomer merged commit c6d5ddb into master Dec 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the sn/rm-IDENTIFIERs branch December 20, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant