Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: findRecord and query request builders #8687

Merged
merged 17 commits into from
Jul 8, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jul 7, 2023

Begins implementation work for @ember-data/request-utils @ember-data/rest/request and @ember-data/json-api/request utility functions for use with store.request and migrating away from store finders, adapters and serializers.

For this PR we will focus on two specific operations: findRecord and query.

Checklist

@ember-data/request-utils

  • buildURL

    • Implemented
    • Tests
  • buildQueryParams

    • Implemented
    • Tests

@ember-data/json-api/request

  • findRecord

    • Implemented
    • Tests
  • query

    • Implemented
    • Tests

@ember-data/rest/request

  • findRecord

    • Implemented
    • Tests
  • query

    • Implemented
    • Tests

@ember-data/active-record/request

  • findRecord

    • Implemented
    • Tests
  • query

    • Implemented
    • Tests

Work by @runspired @natashacwolfe and @jacob-beltran

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Jul 7, 2023
@runspired runspired changed the title feat: request builders feat: findRecord and query request builders Jul 8, 2023
@runspired runspired merged commit 4237849 into emberjs:main Jul 8, 2023
@runspired runspired deleted the request-utils branch July 8, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants