chore: eliminate dead build code #8829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
runspired
commented
Sep 4, 2023
| shouldIncludeChildAddon(addon) { | ||
| if (addon.name.startsWith('@ember-data')) { | ||
| if (addon.name.startsWith('@ember-data/')) { |
There was a problem hiding this comment.
note this is not the broccoli node issue (see the @) but since it could manifest in a similar incorrect check should someone choose a github/npm org starting with @ember-data* we add the /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmberData moved to a new strategy that uses rollup pre-publish some time ago. This removes the vestigial code (that no longer was in use at all) so folks like @mansona stop thinking we still use it 😅
TODO