fix: unloadAll should cleanup live-array membership #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 lts
|
I should mention that the issue in #8924 also occurs when iterating over the record list and unloading each record manually. i.e. |
…8927) * fix: add test for unloadAll not fully cleaning up * fix * fix lint
runspired
force-pushed
the
fix-unload-all
branch
from
9947221
to
031b770
Compare
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for #8924
fix is likely just to wipe record-array membership at the point of the unloadAll
This feels similar to an issue reported before that was already fixed, we might have a fix in later versions already. Will port the test forward to find out.