Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: <Request /> autoRefresh #9363

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: <Request /> autoRefresh #9363

merged 5 commits into from
Apr 18, 2024

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 17, 2024

Enables request auto-refresh behaviors


This PR

  • Test: if no cancelled block is present, abort may be handled by error block
  • Test: if no error block is present, non-abort-error is rethrown
  • Test: if no error block is present, abort-error is not-rethrown
  • Impl: if no error block is present, abort-error is not-rethrown
  • Impl: cancelled block exposes state with retry function
  • Impl: error block exposes state with retry function
  • Test: cancelled block exposes state with retry function
  • Test: error block exposes state with retry function
  • Impl: @Autorefresh enables automatic refresh after background resume
  • Impl: @autorefreshThreshold enables configuration of amount of time in background required before autorefresh will be attempted on resume
  • Impl: @autorefreshBehavior allows 'refresh' 'reload' and 'policy'
  • Test: @Autorefresh enables automatic refresh after background resume
  • Test: @autorefreshThreshold enables configuration of amount of time in background required before autorefresh will be attempted on resume
  • Test: @autorefreshBehavior allows 'reload'
  • Impl: content block exposes state with refresh function
  • Impl: content block exposes state with reload function
  • Impl: content block exposes state with isRefreshing property
  • Impl: content block exposes state with abort function when isRefreshing is true
  • Impl: content block exposes state with latestRequest

Under Consideration / Future PR

  • Test: content block exposes state with refresh function
  • Test: content block exposes state with reload function
  • Test: content block exposes state with isRefreshing property
  • Test: content block exposes state with abort function when isRefreshing is true
  • Test: content block exposes state with latestRequest
  • Test: @autorefreshBehavior allows 'refresh'
  • Test: @autorefreshBehavior allows 'policy'
  • Test/Impl: request subscribes to external updates to the request as background updates
  • Test/Impl: multiple request components dedupe their autorefresh behavior

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Apr 17, 2024
@runspired runspired marked this pull request as ready for review April 18, 2024 09:18
@runspired runspired merged commit f0d1100 into main Apr 18, 2024
23 checks passed
@runspired runspired deleted the more-component-features branch April 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant