[FIXES #150] update babel-preset-env #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
May 31, 2017
index.js
Outdated
| @@ -225,7 +225,7 @@ module.exports = { | |||
| let browsers = targets && targets.browsers; | |||
| let presetOptions = Object.assign({}, options, { | |||
| modules: false, | |||
| targets: { browsers }, | |||
| targets: targets | |||
There was a problem hiding this comment.
Can probably just use shorthand since the names are the same
There was a problem hiding this comment.
does that work in node 4?
stefanpenner
force-pushed
the
babel-preset-env
branch
from
ad1e76b
to
9ccd3a4
Compare
Adding the require for targets-parser from within babel-preset-env pushed us over the budget previously set. This removes timeouts for the first tests that do these requires (bumping the timeout value everytime requiring the giant JSON files babel-preset-env contains is very annoying). We will still get general build timeouts on CI (after 10 minutes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.