Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with latest Babel 7 beta #234

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

dfreeman
Copy link
Contributor

@dfreeman dfreeman commented Aug 3, 2018

This should fix #226 and get things in sync with the most recent Babel 7 beta. A few changes of note:

  • the various @babel packages no longer support node 4, so I updated the engines field and Travis/Appveyor config here to match what I believe is the standard support matrix for new addons today
  • @babel/preset-env is now way pickier about what config it receives, so we need to whitelist the keys we pass in
  • Expose all filenames as absolute paths, rather than relative. babel/babel#8044 means all module paths are now absolute, so our config for Babel itself and amd-name-resolver needed to be tweaked to account for that
  • the latest babel-plugin-debug-macros has a new preferred config format

/cc @rwjblue

@rwjblue rwjblue merged commit 5573a6d into emberjs:babel-7 Aug 3, 2018
@rwjblue
Copy link
Member

rwjblue commented Aug 3, 2018

Awesome, thank you!

@dfreeman dfreeman mentioned this pull request Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants