Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require @babel/preset-env instead of babel-preset-env #238

Closed
wants to merge 3 commits into from

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Aug 5, 2018

We're listing @babel/preset-env as a dependency and so should be using it. 😄

This was the reason for transpilation failing on me for IE11, because some old incompatible transforms are used by babel-preset-env.

AFAICT I can now fully build our TypeScript app with just ember-cli-babel. 😍 🎉

Simple demo repo here: https://github.com/buschtoens/ember-typescript-babel-7

Thank you guys so much. ❤️

Closes #236, because it branched off of it.

@buschtoens
Copy link
Contributor Author

buschtoens commented Aug 5, 2018

One more thing: I added @babel/core@^7.0.0-beta.56 as a dev dep to fix the missing peer dependency. But it should probably be a real dependency, right? Because right now the host app needs to install @babel/core for us. Is this intentional?

@rwjblue
Copy link
Member

rwjblue commented Aug 6, 2018

Because right now the host app needs to install @babel/core for us.

No, broccoli-babel-transpiler has a direct dependency on @babel/core.

@rwjblue
Copy link
Member

rwjblue commented Aug 6, 2018

Can you rebase (@dfreeman got CI passing in #239)?

@buschtoens
Copy link
Contributor Author

No, broccoli-babel-transpiler has a direct dependency on @babel/core.

True! Also noticed that. The problem for me was, that some of my transforms had a peer dep on ^beta.56, but broccoli-babel-transpiler has 42 or something like that.

So I guess this PR is outdated now. I'll rebase #236 instead.

@buschtoens buschtoens closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants