Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid interop issues with babel-plugin-filter-imports RE: decorators syntax #275

Merged

Conversation

pzuraq
Copy link
Collaborator

@pzuraq pzuraq commented Mar 28, 2019

babel-plugin-filter-imports currently adds the internal
decorators plugin so it can parse and remove decorators,
but this conflicts with the actual decorators plugin. This
PR dedupes the plugins for now (and for previous users of
babel-plugin-filter-imports), we'll also release a new major
version of that plugin that doesn't add the internal plugin.

Related: ember-cli/babel-plugin-filter-imports#135

babel-plugin-filter-imports currently adds the internal
`decorators` plugin so it can parse and remove decorators,
but this conflicts with the _actual_ decorators plugin. This
PR dedupes the plugins for now (and for previous users of
babel-plugin-filter-imports), we'll also release a new major
version of that plugin that doesn't add the internal plugin.
@rwjblue rwjblue merged commit 01f129c into emberjs:master Mar 28, 2019
@rwjblue rwjblue added the bug label Mar 28, 2019
@rwjblue rwjblue changed the title [BUGFIX] Dedupe internal decorators plugins [BUGFIX] Avoid interop issues with babel-plugin-filter-imports RE: decorators syntax Mar 28, 2019
@rwjblue rwjblue changed the title [BUGFIX] Avoid interop issues with babel-plugin-filter-imports RE: decorators syntax Avoid interop issues with babel-plugin-filter-imports RE: decorators syntax Mar 28, 2019
@rwjblue
Copy link
Member

rwjblue commented Mar 28, 2019

ember-cli-babel 7.7.1 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants