convert to a v2 addon using ember init #499
Conversation
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "plugins": [ | |||
There was a problem hiding this comment.
these are not needed 🎉
| import makeHelper from '../utils/make-helper'; | ||
| /* eslint-disable prettier/prettier */ | ||
| import { pluralize } from '../index.js'; | ||
| import makeHelper from '../lib/utils/make-helper'; |
There was a problem hiding this comment.
| import makeHelper from '../lib/utils/make-helper'; | |
| import makeHelper from '../lib/utils/make-helper.js'; |
extensions?
| import makeHelper from '../utils/make-helper'; | ||
| /* eslint-disable prettier/prettier */ | ||
| import { singularize } from '../index.js'; | ||
| import makeHelper from '../lib/utils/make-helper'; |
There was a problem hiding this comment.
| import makeHelper from '../lib/utils/make-helper'; | |
| import makeHelper from '../lib/utils/make-helper.js'; |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable prettier/prettier */ | |||
There was a problem hiding this comment.
that's one way to reduce the diff 😅
| "options": [ | ||
| "--no-welcome", | ||
| "--pnpm", | ||
| "--ci-provider=travis" |
There was a problem hiding this comment.
| "--ci-provider=travis" |
There was a problem hiding this comment.
This is progress! 🎉
based on the (lack of) complexity in this addon, I'd like to see it become a real ESM package, and remove all the emberisms (rollup, keywords:[ember-addon], etc) -- but that can happen in a followup (maybe by me)
Only requesting changes because it looks like the types are gone now: https://github.com/emberjs/ember-inflector/blob/master/index.d.ts
Or rather, moved to the wrong location: https://github.com/emberjs/ember-inflector/pull/499/files?file-filters%5B%5D=.mjs&file-filters%5B%5D=.ts&file-filters%5B%5D=dotfile&show-deleted-files=true&show-viewed-files=true#diff-c15cdf855d3b7b7fc0002ed7a70f746102dc73b3a683293063f082e4281a8312
without src being included in files and exports pointing at it: https://github.com/emberjs/ember-inflector/pull/499/files?file-filters%5B%5D=.json&file-filters%5B%5D=.mjs&file-filters%5B%5D=.ts&file-filters%5B%5D=dotfile&show-deleted-files=true&show-viewed-files=true#diff-7c1f47c16eb9ad147fff74bbb9c89a55ebf1e85830bc93695d8f7252f29d7f6aR14-R22
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable prettier/prettier */ | |||
| import { capitalize } from '@ember/string'; | |||
There was a problem hiding this comment.
ember string should be added an a dep or peer -- dep'r'peer
mansona
force-pushed
the
v2-addon
branch
2 times, most recently
from
293a09c to
b5ce4b8
Compare
README.md
Outdated
| @@ -18,66 +15,12 @@ ember install ember-inflector | |||
|
|
|||
| ## Usage | |||
|
|
|||
| All methods are always available from the `ember-inflector` module: | |||
There was a problem hiding this comment.
this should probably come back?
Allows consuming apps to upgrade their version of ember-inflector to v5. See emberjs/ember-inflector#499
I ran
ember init -b @embroider/addon-blueprint --pnpmand moved things around to the right place 👍This PR replaces #498 since it will actually run the CI job