Correctly pluralize floats between 1 and 2 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you investigate the failure with the ember beta test suite? |
|
Can you rebase? I merged #97. Just want to make sure we have all our ducks in a row. |
This fixes emberjs#94 It also adds some test additional test cases to document the current behavior. One additional strange bit is that the float 1.0 is returned as 1 when concatenated into the string. I'm not sure if this is the ideal response but I did not see any clear way to handle keeping that as 1.0 in the returned string. This is the current behavior so changing it might cause some unintended side-effects.
HeroicEric
force-pushed
the
correctly-pluralize-floats
branch
from
63cd0a8
to
2bfa456
Compare
|
rebased and passing again :) |
fivetanley
added a commit
that referenced
this pull request
Dec 8, 2015
Correctly pluralize floats between 1 and 2
|
This is released in 1.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #94
It also adds some test additional test cases to document the current
behavior.
One additional strange bit is that the float 1.0 is returned as 1 when
concatenated into the string. I'm not sure if this is the ideal response
but I did not see any clear way to handle keeping that as 1.0 in the
returned string. This is the current behavior so changing it might
cause some unintended side-effects.
/shrug javascripts